[FP16] Add end to end tests of all the F16x8 intrinisics. #22530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendandahl
force-pushed
the
fp16-test
branch
from
4b8db3a to
78e4b03
Compare
A few todos: - test at other optimization levels - enable liftoff when FP16 is fixed in V8 - test missing instructions
brendandahl
force-pushed
the
fp16-test
branch
from
78e4b03 to
b2e2f11
Compare
tlively
reviewed
Sep 13, 2024
test/test_fp16.c
Outdated
| a = wasm_f16x8_nearest(wasm_f16x8_splat(1.5f)); | ||
| assert_all_lanes_eq(a, 2.0f); | ||
|
|
||
| a = wasm_f16x8_eq(wasm_f16x8_splat(2.0f), wasm_f16x8_splat(3.0f)); |
There was a problem hiding this comment.
It may be worth covering all the interesting cases for the comparisons to ensure we are getting the right comparison at runtime.
| }) | ||
| def test_fp16(self, opts): | ||
| self.v8_args += ['--experimental-wasm-fp16'] | ||
| # TODO Remove this. Liftoff is currently broken for this test. |
There was a problem hiding this comment.
Out of curiosity, do you know what specifically is broken?
There was a problem hiding this comment.
kripken
approved these changes
Sep 16, 2024
test/test_other.py
Outdated
| @requires_v8 | ||
| @parameterized({ | ||
| '': [[]], | ||
| 'O2': [['-O2']] |
There was a problem hiding this comment.
Maybe -O3 for the most coverage?
There was a problem hiding this comment.
Do you recommend in addition to or in replace of O2?
There was a problem hiding this comment.
I would just replace it, as it's practically a superset of -O2.
kripken
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few todos: